Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORM update requires some changes #346

Merged
merged 14 commits into from Jan 28, 2020
Merged

ORM update requires some changes #346

merged 14 commits into from Jan 28, 2020

Conversation

MonkeyDo
Copy link
Contributor

Problem

Updating BookshelfJs to version 1.x requires some changes overall in the codebase, most notable the absence of 'require' flag set to false, fetch and fetchAll now thrown an error.

Solution

Set explicitly if a result is required, and improve error management.

@MonkeyDo
chore: Update bookbrainz-data package (ORM update)
e40c793
@MonkeyDo
chore: Modification after ORM update
97d9689 
See https://github.com/bookshelf/bookshelf/wiki/Migrating-from-0.15.1-to-1.0.0#default-to-require-true-on-modelfetch-and-collectionfetchone
@MonkeyDo
chore: Don't require Achievement and Title types
0cc44ba
@MonkeyDo
chore: Don't require RelationshipSets or relationship Entities
9029948
@MonkeyDo
chore: Don't require old sets when saving entity
4690c53
@MonkeyDo
chore: Don't require entity in search results
d576396
@MonkeyDo
chore: Don't require parent revision
c389bd8
@MonkeyDo
chore: Deal with non-existing revisions
774adb0
@MonkeyDo
chore: Deal with missing models in editor pages
8345df4
@MonkeyDo
fix(ORM-update): require only when necessary when fetching
bd1dbcc 
After bookshelf ORM update to v1.x
@MonkeyDo
chore(ORM-updated): Update ORM package to v2.5.0
ca5717e 
'Require' related fixes relevant to ORM update
@MonkeyDo
chore(ORM-update): Clarify fetch behavior and improve error management
6514854
@MonkeyDo MonkeyDo mentioned this pull request Jan 24, 2020
Merged
@MonkeyDo MonkeyDo marked this pull request as ready for review January 28, 2020 14:23
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 42.799% when pulling e827afc on ORM-update into 40314ad on master.

@MonkeyDo MonkeyDo merged commit 9f92b62 into master Jan 28, 2020
@MonkeyDo MonkeyDo deleted the ORM-update branch January 28, 2020 16:08
@snyk-bot snyk-bot mentioned this pull request Aug 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@MonkeyDo @coveralls