Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Flow type annotation infrastructure and lint TypeScript files #540

Merged
merged 2 commits into from Dec 1, 2020

Conversation

LordSputnik
Copy link
Member

Problem

The repository has numerous referenced to Flow type annotations, which now aren't used in the codebase. It also runs a flow linting plugin, which causes errors during the build process due to a hotfix to an earlier PR. Additionally, the "lint" build task doesn't run any linting on TypeScript files.

Solution

  • Remove the babel and eslint flow plugins
  • Remove the flow type definitions directory (flow-typed)
  • Add the standard typescript-eslint plugin and migrate the rules which have slightly different definitions/checks in TypeScript
  • Update the eslint parser from the babel-eslint parser to the typescript-eslint parser
  • Update CONTRIBUTING.md and NODEJS_SETUP.md to reference TypeScript rather than Flow

Areas of Impact

No functional impact on codebase.

@LordSputnik LordSputnik changed the title Typescript Remove Flow type annotation infrastructure and lint TypeScript files Dec 1, 2020
Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for popping this out so quick :)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 60.847% when pulling 4e0ca49 on LordSputnik:typescript into 091a7de on bookbrainz:master.

@MonkeyDo MonkeyDo merged commit 5ad0e62 into metabrainz:master Dec 1, 2020
@LordSputnik LordSputnik deleted the typescript branch January 20, 2021 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants