Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert relationship editor changes #679

Merged
merged 4 commits into from Jul 30, 2021
Merged

Revert relationship editor changes #679

merged 4 commits into from Jul 30, 2021

Conversation

akashgp09
Copy link
Contributor

@akashgp09 akashgp09 commented Jul 30, 2021 •
edited

Summary:
Reverted some of the relationship editor changes.
A new series component will be created to add series item instead of adding them via the relationship editor.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 61.408% when pulling fa4b202 on akashgp09:revert-relationship-editor-changes into f3897bd on bookbrainz:series-entity.

MonkeyDo
MonkeyDo approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The more I look at it, the more it makes sense to have all this series-specific logic and presentation in a separate component.
Glad you have already got the bulk of the logic done, and it just needs to be moved :)

@MonkeyDo MonkeyDo merged commit f9a9bba into metabrainz:series-entity Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonkeyDo MonkeyDo MonkeyDo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@akashgp09 @coveralls @MonkeyDo