feat(series): separate editor for adding series items #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonkeyDo
requested changes
Aug 16, 2021
There was a problem hiding this comment.
This is looking very nice, well done :)
I think it will make the editing flow much smoother, and we are likely to adapt the same strategy for other entity types in the future (for example Works part of an Edition, with the page attribute on the left-hand side).
This is a great way to refine that workflow with a good use-case, and get feedback from the community.
As I mentioned in one of the comments below I suspect the manual reordering with drag n' drop will be coming in a following PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Created separate editor for adding/editing/removing series item.