Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for first revision is hardcoded as "initial revision" and not respecting the given changelog #5056

Closed
Man-in-Black opened this issue Jun 6, 2024 · 1 comment

Comments

@Man-in-Black
Copy link
Contributor

Describe the Bug

If you set a changelog on the first revision of a page, eg. "Test", this gets not respected and will be overwritten by "intitial revision".
I've found the hardcoded part in the /var/www/bookstack/app/Entities/Repos/PageRepo.php on line 80.

Steps to Reproduce

  1. create a page and put in some content
  2. insert a changelog "Test"
  3. save the page
  4. review the revisions and you will see "initital revision"

Expected Behaviour

The revision should contain the given changelog if set.
if no changelog is set then the default would be fine.

Screenshots or Additional Context

image
Here I put in "Rollenbeschreibung erstellt" as a changelog, but it wasn't stored.

Browser Details

No response

Exact BookStack Version

24.02

@ssddanbrown ssddanbrown added this to the BookStack v24.05.2 milestone Jun 8, 2024
ssddanbrown added a commit that referenced this issue Jun 9, 2024
@ssddanbrown
Copy link
Member

Thanks for raising @Man-in-Black!
I've addressed this via a8ce199, with test to cover, to be part of the next patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants