Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Avatar Caching #5072

Open
1 task done
BloodyIron opened this issue Jun 18, 2024 · 1 comment
Open
1 task done

User Avatar Caching #5072

BloodyIron opened this issue Jun 18, 2024 · 1 comment

Comments

@BloodyIron
Copy link

BloodyIron commented Jun 18, 2024

Describe the feature you'd like

I'm doing some performance tuning for a Bookstack instance I have on a slower environment, and I've noticed that my User Avatar (which pulls from LDAPS/AD) never gets cached by my browser (or allowed to do so), pulling from the server every time.

I think it would be beneficial for User Avatars to be cached in the user's browser upon login (whether #5066 happens or not) such that it only gets replaced in cache when the User's Avatar changes (one way or another), but otherwise stays in the browser.

This User Avatar gets requested from the server on every page load (once logged in) from what I see. While it isn't a huge payload, the wait times from the server seems to (in my case) double the loading time of the page in an avoidable way.

I'm not really seeing any downside to having this aspect cache-able by the browser, so could we please have this added at some point? Thanks! :)

Describe the benefits this would bring to existing BookStack users

All page loading once logging in would be faster due to reduced redundant requests.

Can the goal of this request already be achieved via other means?

Not that I know of.

Have you searched for an existing open/closed issue?

  • I have searched for existing issues and none cover my fundamental request

How long have you been using BookStack?

3 months to 1 year

Additional context

/\ ___ /
( o o )
\ >#< /
/
/ \ ^
| | //
\ / //
/// /// --

@BloodyIron
Copy link
Author

Ugh my kitty got squished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant