Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - JSONPath to Parameter #48

Closed
florentinvintila opened this issue Feb 3, 2022 · 0 comments · Fixed by #56
Closed

Refactor - JSONPath to Parameter #48

florentinvintila opened this issue Feb 3, 2022 · 0 comments · Fixed by #56
Assignees
Labels
enhancement New feature or request project: flow

Comments

@florentinvintila
Copy link
Contributor

florentinvintila commented Feb 3, 2022

File JSONPath To Parameter

Input fields:

  • filePath [mandatory]
  • query [mandatory]

Output fields:

  • evaluation

Things to improve:

  • check/validate mandatory fields (null or empty)
  • debug message on all the input parameters, before the validation
  • make sure that the task's output param can not exceed 4K value, for a standard predefined output param. If there is any chance for a bigger value than 4K (e.g. any GitHub integration that return a response other than OK/NOK) the task MUST define the output file param.

JSONPath To Parameter

Input fields:

  • json [mandatory]
  • query [mandatory]

Output fields:

  • evaluation

Things to improve:

  • check the mandatory field query (empty or null)
  • make sure that the task's output param can not exceed 4K value, for a standard predefined output param. If there is any chance for a bigger value than 4K (e.g. any GitHub integration that return a response other than OK/NOK) the task MUST define the output file param.
@florentinvintila florentinvintila added the enhancement New feature or request label Feb 3, 2022
@florentinvintila florentinvintila changed the title Refactor - Refactor - JSONPath Feb 3, 2022
@florentinvintila florentinvintila self-assigned this Feb 3, 2022
@florentinvintila florentinvintila changed the title Refactor - JSONPath Refactor - JSONPath to Parameter Feb 3, 2022
@tlawrie tlawrie self-assigned this Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request project: flow
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants