Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pilot crashed after reload current level #3

Closed
ccqil opened this issue Apr 4, 2022 · 2 comments · Fixed by #108
Closed

Pilot crashed after reload current level #3

ccqil opened this issue Apr 4, 2022 · 2 comments · Fixed by #108
Assignees
Labels
bug Something isn't working

Comments

@ccqil
Copy link

ccqil commented Apr 4, 2022

If we click Reload Current Level button and then run the editor, pilot will crash.
图片
It seems like that some codes from editor.cpp is wrong:

        if (ImGui::BeginMenuBar())
        {
            if (ImGui::BeginMenu("Menu"))
            {
                if (ImGui::MenuItem("Reload Current Level"))
                {
                    WorldManager::getInstance().reloadCurrentLevel();
                    onGObjectSelected(PILOT_INVALID_GOBJECT_ID);
                }
                if (ImGui::MenuItem("Save Current Level"))
                {
                    WorldManager::getInstance().saveCurrentLevel();
                }
                if (ImGui::MenuItem("Exit"))
                {
                    exit(0);
                }
                ImGui::EndMenu();
            }
            ImGui::EndMenuBar();
        }

the line 343 should not be

onGObjectSelected(PILOT_INVALID_GOBJECT_ID);
@hyv1001 hyv1001 added the bug Something isn't working label Apr 4, 2022
@hyv1001
Copy link
Collaborator

hyv1001 commented Apr 8, 2022

@Ol6rin please check this issue

@Ol6rin
Copy link
Collaborator

Ol6rin commented Apr 8, 2022

Thank you very much for your feedback! The crash is related to unproperly handled PhysicsActors. We're working on the patch code now. It will be released in the next update after passing the test.

@Ol6rin Ol6rin self-assigned this Apr 8, 2022
@Ol6rin Ol6rin mentioned this issue Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants