Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to duplicate less code #24

Closed
hofnerb opened this issue Aug 29, 2016 · 2 comments
Closed

Try to duplicate less code #24

hofnerb opened this issue Aug 29, 2016 · 2 comments
Assignees

Comments

@hofnerb
Copy link
Member

hofnerb commented Aug 29, 2016

@ja-thomas, we should try to use better functional units to avoid duplication of code. Currently, we have a lot of spaghetti code instead of proper functional programming.

Can we aim for that in the next release, i.e. after the initial release of the non-cyclic fitting?

@hofnerb hofnerb changed the title Try to duplicate code less Try to duplicate less code Aug 29, 2016
@hofnerb
Copy link
Member Author

hofnerb commented Aug 29, 2016

Perhaps we can furthermore already use object orientation within the fitting algorithm

@ja-thomas
Copy link
Member

Should be better now. The code could be made nicer in the future, but that would require major refactoring (maybe even some on mboost). I don't think I have the time for that currently, but we can keep the issue open if you want to.

@hofnerb hofnerb closed this as completed Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants