Clang7 fix #354
Merged
Clang7 fix #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - Reveal.js pdf print has wrong path to the css. Solution: - Fix the path.
Problem: - Clang7 has different behaviour when deducing templated implicit conversion operator using rvalue. Solution: - Add case for rvalue reference.
krzysztof-jusiak
force-pushed
the
clang7_fix
branch
from
b3342a2
to
c96485e
Compare
Codecov Report
@@ Coverage Diff @@
## cpp14 #354 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 79 79
Lines 2909 2909
=======================================
Hits 2866 2866
Misses 43 43
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
Issue: #
Reviewers:
@