Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default asset-path should respect .cljs.edn position #152

Closed
arichiardi opened this issue Mar 8, 2017 · 2 comments
Closed

Default asset-path should respect .cljs.edn position #152

arichiardi opened this issue Mar 8, 2017 · 2 comments

Comments

@arichiardi
Copy link
Contributor

arichiardi commented Mar 8, 2017 •
edited
Loading

Hi Deraen,

I was fiddling with a boot-figreload bug and noticed that when you don't explicitely specify the :asset-path option, boot-cljs calls get-name for figuring out which asset-path to use.

Unless I am doing something wrong, it should respect the position where you put the .cljs.edn file I guess.

EDIT: I have a repro here: https://github.com/arichiardi/figreload-demo/tree/boot-cljs-152
@Deraen
Copy link
Contributor

Deraen commented Mar 8, 2017

Aha, interesting, I thought it would use getPath.

@caleb caleb mentioned this issue Mar 20, 2017
Merged
@Deraen
Copy link
Contributor

Deraen commented Apr 3, 2017

Fixes in #156

@Deraen Deraen closed this as completed Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Deraen @arichiardi