Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --uber option to jar, war tasks #118

Closed
alandipert opened this issue Feb 2, 2015 · 2 comments
Closed

Add --uber option to jar, war tasks #118

alandipert opened this issue Feb 2, 2015 · 2 comments
Assignees
Milestone

Comments

@alandipert
Copy link
Contributor

The uber task is notoriously slow because it dumps static, exploded dependencies into the fileset on every build. It does this so subsequent jar or war tasks can see all the files that need to go into the jar. See #94 for a full discussion of the problem.

We think the best way to address the problem is by adding an --uber option to jar and war. That way, instead of needing to explode dependencies into the fileset, these tasks will pack dependencies directly into the jar/war being built, and only this "packed" jar goes on the fileset.

It doesn't feel like a great solution because we're loathe to fix a performance problem between two tasks by combining them. However, we can't think of a better way, and also think uber jars are probably a special case.

The plan is to have this in for 2.0, whether or not we should also deprecate the uber task is a good question. I think probably yes.

@alandipert alandipert added this to the 2.0.0 milestone Feb 2, 2015
@alandipert alandipert self-assigned this Feb 2, 2015
@bobby
Copy link

bobby commented Mar 2, 2015

One datapoint: I've used the uber task with :as-jars to build zips with a lib/*.jar dir (uberzip?). So the capability of stashing jar'd deps on the fileset is a useful capability, whether tied to uber or not.

@micha micha added the ready label Mar 9, 2015
@micha micha removed the ready label May 21, 2015
@alandipert alandipert reopened this May 21, 2015
@alandipert alandipert modified the milestones: future, 2.0.0 May 21, 2015
@micha
Copy link
Contributor

micha commented Dec 19, 2015

I think the uber task is pretty fast now. Feel free to reopen if we want to revisit this.

@micha micha closed this as completed Dec 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants