Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch task broken if project directory is not same as git work directory #20

Closed
Deraen opened this issue Nov 20, 2014 · 2 comments
Closed
Labels
Milestone

Comments

@Deraen
Copy link
Contributor

Deraen commented Nov 20, 2014

https://github.com/boot-clj/boot/blob/master/boot/core/src/boot/task/built_in.clj#L152

Watch task checks if the changed file is in git index. ls-files returns a set of files relative to git work directory. Watch task checks if the set contains changed file but the changed file is relative to project directory.

ls-files could be fixed to return set of files relative to project directory...
But perhaps it makes more sense to just remove gitignore-matcher: only src- and rsc-paths are watched for changes so not too many uninteresting files should trigger change.

@alandipert
Copy link
Contributor

I'm for removing gitignore-matcher also. It was only really useful when . was added as a src automatically, which we will stop doing. Maybe it could be useful as a separate task for adding/removing to src/rsc based on .gitignore.

@micha
Copy link
Contributor

micha commented Nov 21, 2014

The gitignore matcher is really hard to implement correctly. There are all kinds of weird corner cases involved, and it's not actually that useful. Not so useful that it needs to be in the core anyway. So I'm also for removing it. It will begone!

@micha micha added the Bug label Nov 21, 2014
@micha micha added this to the 2.0.0-rc1 milestone Nov 21, 2014
@micha micha closed this as completed in 38c4fd7 Nov 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants