Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge should work for projects own resources too #217

Closed
kul opened this issue Jun 4, 2015 · 4 comments
Closed

Merge should work for projects own resources too #217

kul opened this issue Jun 4, 2015 · 4 comments
Labels
Milestone

Comments

@kul
Copy link
Contributor

kul commented Jun 4, 2015

Here is the problem i am facing which i think would be pretty common for others too.
One of the data_readers.clj is inside one of the jar files and other is in my resources folder.
Since resources gets copied in a different step from uber step, the .exists method in unpack-jar will return false for it causing the uber step to overwrite the fileset without actually merging.

I guess the mergers would need to be applied at commit! too. WDYT?

@micha
Copy link
Contributor

micha commented Jun 7, 2015

Nice! Thanks for reporting this! It sounds totally reasonable to me. I'll work up a patch and run it by @tobias for review.

Are you also recommending that we merge data_readers.clj files? What about deps.cljs? Are there any other non-namespaced Clojure/ClojureScript files in JARS that we need to merge when uberizing? A separate ticket for those would be appropriate, probably.

@micha micha added the Bug label Jun 7, 2015
@micha micha added this to the 2.2.0 milestone Jun 7, 2015
@micha
Copy link
Contributor

micha commented Jun 7, 2015

Whoops, my bad, data_readers.clj is already in the merge list, please disregard that part 😄

@micha micha closed this as completed in 09eadb0 Jun 10, 2015
@kul
Copy link
Contributor Author

kul commented Jun 11, 2015

Works Perfectly! Thanks @micha

@tobias
Copy link
Contributor

tobias commented Jun 11, 2015

Thank you @kul for catching this, and thank you @micha for fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants