prevent duplicate tagging of commits during push #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinklepsch
force-pushed
the
tag-only-if-untagged
branch
from
a118d28
to
48de2e3
Compare
Closed
martinklepsch
added a commit
that referenced
this pull request
Oct 30, 2015
It's real! 🎉 🎊. Closes #329 - `make install` can still be used to install everything locally. - `boot build (--watch) (--install)` can be used during development. It will start multiple boot pipelines to build boot libraries when relevant files change. It **is required** to run `make install` before doing this*. Reason for this is that `make install` copies the aether uberjar into `boot/base/resources` where it will be picked up when building the base uberjar (`boot.jar`). If the aether uberjar is not present building the base uberjar will fail. - `make deploy` uses the regular `push-release` provided by bootlaces. I'm not sure how to test this without making a release or creating garbage on clojars, any ideas? Also #328 would be needed. - There was a `:jar-exclusions [#"^clojure/core/"]` in all `project.clj`s but I don't think that had any effect. Leiningen provides `:uberjar-exclusions` for uberjars where it would make sense but we don't use that. - Limitation: We cannot install the version of boot we're currently running. This "will pull the carpet under the feet" of the running process. In practice this isn't a big problem I think but worth mentioning. :beers:
martinklepsch
added a commit
that referenced
this pull request
Oct 30, 2015
It's real! 🎉 🎊. Closes #329 - `make install` can still be used to install everything locally. - `boot build (--watch) (--install)` can be used during development. It will start multiple boot pipelines to build boot libraries when relevant files change. It **is required** to run `make install` before doing this*. Reason for this is that `make install` copies the aether uberjar into `boot/base/resources` where it will be picked up when building the base uberjar (`boot.jar`). If the aether uberjar is not present building the base uberjar will fail. - `make deploy` uses the regular `push-release` provided by bootlaces. I'm not sure how to test this without making a release or creating garbage on clojars, any ideas? Also #328 would be needed. - There was a `:jar-exclusions [#"^clojure/core/"]` in all `project.clj`s but I don't think that had any effect. Leiningen provides `:uberjar-exclusions` for uberjars where it would make sense but we don't use that. - Limitation: We cannot install the version of boot we're currently running. This "will pull the carpet under the feet" of the running process. In practice this isn't a big problem I think but worth mentioning. :beers:
|
👍 looks great |
micha
added a commit
that referenced
this pull request
Nov 1, 2015
prevent duplicate tagging of commits during push
martinklepsch
added a commit
that referenced
this pull request
Nov 4, 2015
It's real! 🎉 🎊. Closes #329 - `make install` can still be used to install everything locally. - `boot build (--watch) (--install)` can be used during development. It will start multiple boot pipelines to build boot libraries when relevant files change. It **is required** to run `make install` before doing this*. Reason for this is that `make install` copies the aether uberjar into `boot/base/resources` where it will be picked up when building the base uberjar (`boot.jar`). If the aether uberjar is not present building the base uberjar will fail. - `make deploy` uses the regular `push-release` provided by bootlaces. I'm not sure how to test this without making a release or creating garbage on clojars, any ideas? Also #328 would be needed. - There was a `:jar-exclusions [#"^clojure/core/"]` in all `project.clj`s but I don't think that had any effect. Leiningen provides `:uberjar-exclusions` for uberjars where it would make sense but we don't use that. - Limitation: We cannot install the version of boot we're currently running. This "will pull the carpet under the feet" of the running process. In practice this isn't a big problem I think but worth mentioning. :beers:
martinklepsch
added a commit
that referenced
this pull request
Nov 8, 2015
It's real! 🎉 🎊. Closes #329 - `make install` can still be used to install everything locally. - `boot build (--watch) (--install)` can be used during development. It will start multiple boot pipelines to build boot libraries when relevant files change. It **is required** to run `make install` before doing this*. Reason for this is that `make install` copies the aether uberjar into `boot/base/resources` where it will be picked up when building the base uberjar (`boot.jar`). If the aether uberjar is not present building the base uberjar will fail. - `make deploy` uses the regular `push-release` provided by bootlaces. I'm not sure how to test this without making a release or creating garbage on clojars, any ideas? Also #328 would be needed. - There was a `:jar-exclusions [#"^clojure/core/"]` in all `project.clj`s but I don't think that had any effect. Leiningen provides `:uberjar-exclusions` for uberjars where it would make sense but we don't use that. - Limitation: We cannot install the version of boot we're currently running. This "will pull the carpet under the feet" of the running process. In practice this isn't a big problem I think but worth mentioning. :beers:
martinklepsch
added a commit
that referenced
this pull request
Nov 8, 2015
It's real! 🎉 🎊. Closes #329 - `make install` can still be used to install everything locally. - `boot build (--watch) (--install)` can be used during development. It will start multiple boot pipelines to build boot libraries when relevant files change. It **is required** to run `make install` before doing this*. Reason for this is that `make install` copies the aether uberjar into `boot/base/resources` where it will be picked up when building the base uberjar (`boot.jar`). If the aether uberjar is not present building the base uberjar will fail. - `make deploy` uses the regular `push-release` provided by bootlaces. I'm not sure how to test this without making a release or creating garbage on clojars, any ideas? Also #328 would be needed. - There was a `:jar-exclusions [#"^clojure/core/"]` in all `project.clj`s but I don't think that had any effect. Leiningen provides `:uberjar-exclusions` for uberjars where it would make sense but we don't use that. - Limitation: We cannot install the version of boot we're currently running. This "will pull the carpet under the feet" of the running process. In practice this isn't a big problem I think but worth mentioning. :beers:
martinklepsch
added a commit
that referenced
this pull request
Nov 8, 2015
It's real! 🎉 🎊. Closes #329 - `make install` can still be used to install everything locally. - `boot build (--watch) (--install)` can be used during development. It will start multiple boot pipelines to build boot libraries when relevant files change. It **is required** to run `make install` before doing this*. Reason for this is that `make install` copies the aether uberjar into `boot/base/resources` where it will be picked up when building the base uberjar (`boot.jar`). If the aether uberjar is not present building the base uberjar will fail. - `make deploy` uses the regular `push-release` provided by bootlaces. I'm not sure how to test this without making a release or creating garbage on clojars, any ideas? Also #328 would be needed. - There was a `:jar-exclusions [#"^clojure/core/"]` in all `project.clj`s but I don't think that had any effect. Leiningen provides `:uberjar-exclusions` for uberjars where it would make sense but we don't use that. - Limitation: We cannot install the version of boot we're currently running. This "will pull the carpet under the feet" of the running process. In practice this isn't a big problem I think but worth mentioning. :beers:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.