Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vestigial -t, -T boot cli options and :target-path environment entry #475

Closed
esp1 opened this issue Jun 30, 2016 · 2 comments
Closed
Assignees
Milestone

Comments

@esp1
Copy link

esp1 commented Jun 30, 2016

The boot cli still shows -t and -T options to set (or unset) the target path, even though those options no longer have any effect. Similarly, there is a :target-path entry in the boot environment which no longer affects the target task. These should be removed as their continued presence is misleading.

@esp1
Copy link
Author

esp1 commented Jul 1, 2016

Hmm. removing :target-path could be tricky. There are third party tasks that make use of this, e.g. https://github.com/adzerk-oss/boot-reload/blob/bb26bdabb6529668bfc42f6ba759cf70e13a7e8b/src/adzerk/boot_reload.clj#L62

@Deraen
Copy link
Contributor

Deraen commented Jul 2, 2016

Boot-reload doesn't really need it. It is only used in a rare case which can be replaced with separate option if needed.

@micha micha added this to the 2.6.1 milestone Jul 29, 2016
@micha micha added the ready label Jul 30, 2016
@micha micha self-assigned this Jul 30, 2016
@micha micha closed this as completed in 32b0425 Jul 30, 2016
@micha micha removed the ready label Jul 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants