Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo in terminal-notifier for OSX #478

Closed
esp1 opened this issue Jul 8, 2016 · 0 comments
Closed

typo in terminal-notifier for OSX #478

esp1 opened this issue Jul 8, 2016 · 0 comments
Assignees
@micha
Labels
Bug
Milestone
2.7.0

Comments

@esp1
Copy link

esp1 commented Jul 8, 2016 •
edited by micha

There is a typo here which causes the notify task on OSX not to be able to find the terminal-notifier program: https://github.com/boot-clj/boot/blob/master/boot/core/src/boot/task_helpers/notify.clj#L35

Should be terminal-notifier instead of terminal_notifier
@micha micha added the Bug label Jul 29, 2016
@micha micha added this to the 2.6.1 milestone Jul 29, 2016
@micha micha added the ready label Jul 30, 2016
@micha micha self-assigned this Jul 30, 2016
@micha micha closed this as completed in 65cbfc8 Jul 30, 2016
@micha micha removed the ready label Jul 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@micha micha

Labels
Bug
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
2 participants
@micha @esp1