Fix path format for fake.class.path on Windows
#488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `fake.class.path` env variable is currently populated in a way that leaves an extraneous leading forward slash character at the start of all path components on Windows, so that: "C:\\Program Files\\Java\\jdk1.8.0_77\\jre\\lib\\ext\\access-bridge-64.jar" Ends up being represented as: "/C:/Program Files/Java/jdk1.8.0_77/jre/lib/ext/access-bridge-64.jar" This patch uses `java.nio.file.Paths` to properly convert each component of the classpath to a valid system-specific path before using it to populate the `fake.class.path` variable.
|
Looks great, thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fake.class.pathenv variable is currently populated in a way thatleaves an extraneous leading forward slash character at the start of all
path components on Windows, so that:
"C:\Program Files\Java\jdk1.8.0_77\jre\lib\ext\access-bridge-64.jar"
Ends up being represented as:
"/C:/Program Files/Java/jdk1.8.0_77/jre/lib/ext/access-bridge-64.jar"
This patch uses
java.nio.file.Pathsto properly convert each componentof the classpath to a valid system-specific path before using it to
populate the
fake.class.pathvariable.