Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX notify throws IllegalArgumentException #491

Closed
esp1 opened this issue Aug 9, 2016 · 3 comments
Closed

OSX notify throws IllegalArgumentException #491

esp1 opened this issue Aug 9, 2016 · 3 comments
Labels
Milestone

Comments

@esp1
Copy link

esp1 commented Aug 9, 2016

There is one more issue with the notify task on OSX. It attempts to pull a value for a :pid key from the input argument map, but that value is never set, resulting in the following exception when the task is run:

java.lang.IllegalArgumentException: No value supplied for key: null

Perhaps this should be :uid instead?

@micha
Copy link
Contributor

micha commented Aug 9, 2016

How can this be reproduced?

@esp1
Copy link
Author

esp1 commented Aug 9, 2016

Just run boot notify on OSX, it will throw the exception

@esp1
Copy link
Author

esp1 commented Aug 9, 2016

The root of the issue is that the boot notify task provides sensible default values for :title,:uid, :icon, and :messages in the options map it sends to the notify-method multimethod, but the OSX defmethod expects to find a :pid key, which is never populated. The shell/sh command then dies with the above exception because pid is nil. It seems like a simple typo and that :pid should be :uid, which is defaulted appropriately in the notify task.

@micha micha added this to the 2.7.0 milestone Aug 12, 2016
@micha micha closed this as completed in fd79348 Aug 12, 2016
@micha micha removed the ready label Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants