Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update chart to use redis 14.1. X subchart #49

Closed
jsalatiel opened this issue May 17, 2021 · 5 comments
Closed

Please update chart to use redis 14.1. X subchart #49

jsalatiel opened this issue May 17, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jsalatiel
Copy link

Please update this chart to use redis 14.1.X subchart. Bitnami/redis 14.1.x has fixed lots of problems in Sentinel.

@modzilla99
Copy link

I tried using the newest redis 14.3.3 chart by changing the Chart.yml, while this works, it does make it so that the netbox.yml points to Port 0. When changing it manually afterwards it will begin to work like normal.

Any ideas @bootc?

@modzilla99
Copy link

modzilla99 commented Jun 3, 2021

To reproduce:

Chart.yml

apiVersion: v2
name: netbox
version: 3.0.0
appVersion: v2.10.4
description: IP address management (IPAM) and data center infrastructure management (DCIM) tool
home: https://github.com/bootc/netbox-chart
icon: https://raw.githubusercontent.com/netbox-community/netbox/develop/docs/netbox_logo.png
maintainers:
- name: Chris Boot
  email: bootc@boo.tc
  url: https://github.com/bootc
dependencies:
- name: postgresql
  version: 10.x.x
  repository: https://charts.bitnami.com/bitnami
  condition: postgresql.enabled
- name: redis
  version: 14.3.x
  repository: https://charts.bitnami.com/bitnami
  condition: redis.enabled
# helm install --dry-run --set tasksRedis.port=6379 netbox netbox-chart/ | grep -A10 REDIS:
    REDIS:
      tasks:
        HOST: "netbox-redis-master"
        PORT: 0
        DATABASE: 0
        SSL: false
      caching:
        HOST: "netbox-redis-master"
        PORT: 0
        DATABASE: 1
        SSL: false

@modzilla99
Copy link

I am lost. It doesn't even work upstream:

# helm install --dry-run --repo https://charts.boo.tc --set cachingRedis.port=234 --set Redis.port=6378 netbox netbox | grep -A10 REDIS:
    REDIS:
      tasks:
        HOST: "netbox-redis-master"
        PORT: 6379
        DATABASE: 0
        SSL: false
      caching:
        HOST: "netbox-redis-master"
        PORT: 6379
        DATABASE: 1
        SSL: false

or

# cat v1.yml
tasksRedis:
  port: 6378

cachingRedis:
  port: 123456
# helm install --dry-run --repo https://charts.boo.tc --values v1.yml netbox netbox | grep -A10 REDIS:
    REDIS:
      tasks:
        HOST: "netbox-redis-master"
        PORT: 6379
        DATABASE: 0
        SSL: false
      caching:
        HOST: "netbox-redis-master"
        PORT: 6379
        DATABASE: 1
        SSL: false

@bootc
Copy link
Member

bootc commented Sep 9, 2021

The ConfigMap refers to:

    REDIS:
      tasks:
[...]
        PORT: {{ .Values.redis.redisPort | int }}

This matches how you change the port number in version 12.x of the Bitnami chart, so you should be able to change the port to match by using that value even though it's ignored by the Redis chart.

I'll probably upgrade to a newer Redis chart soon, but it'll mean a major version bump for the NetBox chart too so I'm not going to undertake this lightly.

@bootc bootc self-assigned this Sep 9, 2021
@bootc bootc added the enhancement New feature or request label Sep 9, 2021
@bootc bootc added the pending Issue is in a branch waiting for a release label Nov 27, 2021
@bootc bootc added this to the 4.0 milestone Nov 27, 2021
@bootc bootc closed this as completed in e0f2856 Nov 29, 2021
@bootc bootc removed the pending Issue is in a branch waiting for a release label Nov 29, 2021
@bootc
Copy link
Member

bootc commented Nov 29, 2021

I've just released version 4.0.1 of this chart which resolves this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants