Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker HPA broken #51

Closed
jweiher opened this issue Jun 1, 2021 · 3 comments
Closed

Worker HPA broken #51

jweiher opened this issue Jun 1, 2021 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jweiher
Copy link

jweiher commented Jun 1, 2021

Hi,

I tried to use the worker hpa but it fails because of an undefined template:
netbox/templates/worker-hpa.yaml:7:8: executing \"netbox/templates/worker-hpa.yaml\" at <include \"netbox.worker.labels\" .>: error calling include: template: no template \"netbox.worker.labels\" associated with template \"gotpl\"\n"
I'm not that familiar with helm but from my perspective the fix might just be changing the netbox.worker.labels to netbox.labels in worker-hpa.yaml?

kind regards,
Jan

@bootc bootc self-assigned this Sep 9, 2021
@bootc bootc added the bug Something isn't working label Sep 9, 2021
@bootc
Copy link
Member

bootc commented Sep 13, 2021

This is easy enough to fix, but come to think of it is there a valid use case for running more than one worker instance? Would it be more correct to remove the HPA and restrict the worker Deployment to only 1 replica?

@jweiher
Copy link
Author

jweiher commented Oct 29, 2021

Hi,

sorry I did not notice your reply.

We are currently using 4 workers for our deployment. With a lot of data in netbox and maybe (like in our case) some plugins that do use the workers as well it makes perfect sense to have more than one, especially if you have some longer running tasks that block a single worker.

-- Jan

@bootc bootc added the pending Issue is in a branch waiting for a release label Nov 27, 2021
@bootc bootc added this to the 4.0 milestone Nov 27, 2021
@bootc bootc closed this as completed in 2634db0 Nov 29, 2021
@bootc bootc removed the pending Issue is in a branch waiting for a release label Nov 29, 2021
@bootc
Copy link
Member

bootc commented Nov 29, 2021

I've just released version 4.0.1 of this chart which resolves this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants