Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worker missing worker specific environment variables #53

Closed
jeremypng opened this issue Jun 29, 2021 · 2 comments
Closed

Worker missing worker specific environment variables #53

jeremypng opened this issue Jun 29, 2021 · 2 comments
Assignees
@bootc
Labels
bug Something isn't working
Milestone
4.0

Comments

@jeremypng
Copy link

Line 55 of netbox-chart/templates/worker-deployment.yaml only grabs the global extraEnvs and not the ones under the worker key.
@bootc
Copy link
Member

bootc commented Sep 9, 2021

You're right, and there's a similar issue with extraVolumes as well. I'm queuing up a fix for this.

@bootc bootc self-assigned this Sep 9, 2021
@bootc bootc added the bug Something isn't working label Sep 9, 2021
@bootc bootc added the pending Issue is in a branch waiting for a release label Nov 27, 2021
@bootc bootc added this to the 4.0 milestone Nov 27, 2021
@bootc bootc closed this as completed in 8f41c5f Nov 29, 2021
@bootc bootc removed the pending Issue is in a branch waiting for a release label Nov 29, 2021
@bootc
Copy link
Member

bootc commented Nov 29, 2021

I've just released version 4.0.1 of this chart which resolves this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bootc bootc

Labels
bug Something isn't working
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
2 participants
@bootc @jeremypng