Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media storage config for S3 backend in existingSecret #56

Closed
dimitrigraf opened this issue Aug 20, 2021 · 4 comments
Closed

Media storage config for S3 backend in existingSecret #56

dimitrigraf opened this issue Aug 20, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dimitrigraf
Copy link
Contributor

The chart allows to have almost all of the credentials in an existing secret and therefore not to have them in the values.yaml.

The only credentials that can not yet be extracted like that are the credentials (storageConfig) for the media storage backend.

Enabling that would be much appreciated. Thanks in advance!

Cheers.

@bootc
Copy link
Member

bootc commented Sep 9, 2021

The trouble is this requires domain-specific knowledge for the storage provider(s) you want to use.

Really this chart needs a way to add arbitrary additional configuration settings from other ConfigMaps and Secrets or similar, but that's not straightforward. I'll put some thought into it.

@bootc bootc self-assigned this Sep 9, 2021
@bootc bootc added the enhancement New feature or request label Sep 9, 2021
@bootc bootc added this to the 4.0 milestone Nov 27, 2021
@bootc
Copy link
Member

bootc commented Nov 28, 2021

My plan for this is to let people supply arbitrary ConfigMaps and Secrets, and any *.yaml keys within those secrets will be treated as configuration, and imported into NetBox's configuration. I'd like to do similar for *.py but that may need to wait for a future update as I don't want to delay releasing version 4.0 of the chart.

@bootc bootc added the pending Issue is in a branch waiting for a release label Nov 28, 2021
@bootc bootc closed this as completed in 2131bee Nov 29, 2021
@bootc bootc removed the pending Issue is in a branch waiting for a release label Nov 29, 2021
@bootc
Copy link
Member

bootc commented Nov 29, 2021

I've just released version 4.0.1 of this chart which resolves this issue.

@dimitrigraf
Copy link
Contributor Author

Hi there @bootc

I'm not sure if you'll see this if the issue is closed but I'll try anyway.

So, I was trying out the extraConfig field today because I wanted to extract the S3 config to an existing secret like discussed above. But, at some point I realized that this is not going to work because the mechanism creates files with the filename being the key and the value being the file content.

I just tried and get a botocore exception saying that the credentials couldn't be found. The container does have the files though:

bash-5.1$ ls /run/config/extra/0/
AWS_ACCESS_KEY_ID      AWS_SECRET_ACCESS_KEY

Did I misunderstand something? I guess so...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants