Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version label not set properly #57

Closed
dimitrigraf opened this issue Sep 10, 2021 · 1 comment
Closed

version label not set properly #57

dimitrigraf opened this issue Sep 10, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dimitrigraf
Copy link
Contributor

dimitrigraf commented Sep 10, 2021

This is a rather cosmetic one but might still be important and should be easy to fix I guess:

When using a different netbox version than the one specified in the Chart.yaml by setting image.tag, the version label app.kubernetes.io/version is not set properly.

I guess that's due to the label being set like this: templates/_helpers.tpl:app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}

I'm not really experienced with go templates but maybe it should be sth like the following:
{{ .Values.image.tag | default .Chart.AppVersion | quote }}

@bootc bootc self-assigned this Sep 13, 2021
@bootc bootc added the enhancement New feature or request label Sep 13, 2021
@bootc bootc added the pending Issue is in a branch waiting for a release label Nov 27, 2021
@bootc bootc added this to the 4.0 milestone Nov 27, 2021
@bootc bootc closed this as completed in a2ffe6a Nov 29, 2021
@bootc bootc removed the pending Issue is in a branch waiting for a release label Nov 29, 2021
@bootc
Copy link
Member

bootc commented Nov 29, 2021

I've just released version 4.0.1 of this chart which resolves this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants