Make readiness probe configurable #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you had a chance to look at this @bootc ? |
|
Thanks for your contribution, sorry about the delay. |
bootc
pushed a commit
that referenced
this pull request
Jul 26, 2022
#81 breaks the helm chart when a value for `.Values.allowedHosts` is used. `httpHeaders` is a subkey of `httpGet` and the newly added values are siblings of `httpGet`. Putting those new values between `httpGet` and `httpHeaders` breaks the position and indentation of `httpHeaders`. As a solution this commit moves the new values after `httpHeaders`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to allow for more flexibility in the readiness probe configuration. This was causing events in our NetBox set up and allowing for a longer timeout resolved this.