Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(table): Add no-sort-reset prop (#1784)
- Loading branch information
1 parent
fa60d56
commit 26aaeab
Showing
4 changed files
with
47 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26aaeab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might have been better implemented by making the sortable column headers tri-state click... i.e. cycle from asc (false) => desc (true) => no sort (null) => asc (false) => desc (true) => etc,, and removing the click handlers on the non-sortable headers. This would make for a better user interface design.