feat(): add a extra-toggle-classes prop to nav-item-dropdown.js with … #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests and docs. Refs bootstrap-vue#1550
Codecov Report
@@ Coverage Diff @@
## dev #1555 +/- ##
=======================================
Coverage 53.81% 53.81%
=======================================
Files 134 134
Lines 2191 2191
Branches 698 698
=======================================
Hits 1179 1179
Misses 721 721
Partials 291 291
Continue to review full report at Codecov.
|
|
Hey. Thanks for this PR. What's your idea if we simplify prop name |
|
Hi!
Sounds good, but it sounds more like an override rather than an additional
class. Ideally I'd like to have a common prop available for every type of
component like this. I only spent last night and this morning looking
around the project design to do enough to get this to work.
I know I'll need more of these migrating my static bs4 theme to bs vue.
Thanks.
|
pi0
approved these changes
Jan 23, 2018
|
Seems reasonable for naming. Thanks again for PR. Will be available soon in |
|
Update: it is available with both |
|
Sorry, missed this! Excellent. Thank you so much.
|
|
I have a doc correction:
should be
best way to fix? Another PR? |
|
Ah fixed. Thanks for notifing :) |
|
Have now upgraded and working perfectly. Thanks for building such a great
project.
…On 28 Jan 2018 18:58, "Pooya Parsa" ***@***.***> wrote:
Ah fixed. Thanks for notifing :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1555 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJveAX0-VvyTPCGgSReXX4k04mi6X4Wks5tPMM7gaJpZM4RpkoB>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tests and docs. Refs #1550