Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): Add the sort-direction prop #1788

Merged
merged 3 commits into from May 17, 2018

Conversation

emanuelmutschlechner
Copy link
Contributor

Closes #1783.

Improvements for docs are welcome

@codecov
Copy link

codecov bot commented Apr 29, 2018

Codecov Report

Merging #1788 into dev will increase coverage by 0.02%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1788      +/-   ##
==========================================
+ Coverage   61.02%   61.05%   +0.02%     
==========================================
  Files         154      154              
  Lines        2861     2868       +7     
  Branches      790      793       +3     
==========================================
+ Hits         1746     1751       +5     
- Misses        800      801       +1     
- Partials      315      316       +1
Impacted Files Coverage Δ
src/components/table/table.js 76.23% <77.77%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26aaeab...13489b2. Read the comment docs.

@emanuelmutschlechner
Copy link
Contributor Author

Any ideas for tests?

@mpranjic
Copy link

Wow, this was fast.

How about this setting can be provided per-column instead of per-table ?

@emanuelmutschlechner
Copy link
Contributor Author

You can test it here
https://codesandbox.io/s/x9k8l9nko4

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes!

@pi0 pi0 merged commit 9e1959d into bootstrap-vue:dev May 17, 2018
@pi0
Copy link
Member

pi0 commented May 17, 2018

Thanks :)

@emanuelmutschlechner emanuelmutschlechner deleted the feat-table-advanced-sort branch October 26, 2018 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants