Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs are missing an example/docs #179

Closed
asafyish opened this issue Mar 27, 2017 · 7 comments
Closed

Tabs are missing an example/docs #179

asafyish opened this issue Mar 27, 2017 · 7 comments
Assignees

Comments

@asafyish
Copy link

I can see that tabs are implemented, but missing an example/docs,
It will be really helpful to have either 馃檹

@pi0
Copy link
Member

pi0 commented Mar 27, 2017

@mosinve Could you help us on it? We need only some jsFiddle example for this. (component docs are auto generated) 馃檹

@mosinve
Copy link
Member

mosinve commented Mar 27, 2017

Yeah, I'll do)

@mosinve
Copy link
Member

mosinve commented Mar 27, 2017

https://jsfiddle.net/cihkem/rk7w0f2b/ here it is:)
BTW, tabs in need of further refactoring.
And, we alredy have tabs in Nav component, i mean do we really need another tabs?

@pi0
Copy link
Member

pi0 commented Mar 27, 2017

@mosinve Thanks :) I agree about refactoring, Do you will to contribute? I can open a PR with some basic refactors before release, or we just can add docs for current release if tabs are stable enough. (I've no idea because not using them in my projects currently)

@mosinve
Copy link
Member

mosinve commented Mar 27, 2017

In general, they are quite stable, and IMHO the public part should not heavily change. so we can make the documentation, and then refactor.
i think main changes will be at transitions support, and some Vue programming style refactoring. I have a bedtime in my TZ now, so I can work on tabs tomorrow :)

@pi0
Copy link
Member

pi0 commented Mar 27, 2017

@mosinve OK :) I will prepare docs till tomorrow :) Thanks

@pi0
Copy link
Member

pi0 commented Mar 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants