fix(modal) optimize model.resetScrollbar , resolves #1831 #1837
Conversation
…s done in the first place, resolves bootstrap-vue#1831
Codecov Report
@@ Coverage Diff @@
## dev #1837 +/- ##
==========================================
+ Coverage 61.04% 64.66% +3.62%
==========================================
Files 154 154
Lines 2862 2870 +8
Branches 791 792 +1
==========================================
+ Hits 1747 1856 +109
+ Misses 800 727 -73
+ Partials 315 287 -28
Continue to review full report at Codecov.
|
|
Is there anything we can do to get this merged? |
* dev: (31 commits) feat(card): support left and right image placement (bootstrap-vue#1981) fix(collapse/toggle): "collapsed" class cleared when component updated (bootstrap-vue#2102) fix(form-file): Add validation of single file (bootstrap-vue#2028) chore(docs): minor update to the b-form-input docs chore(docs): Minor update to b-form-input docs feat(table): Add row-unhovered event (bootstrap-vue#1874) feat(table): Support contextmenu event binding for table rows (bootstrap-vue#2064) docs(table): fix minor typo (bootstrap-vue#2093) feat(table): Support sorting on nested object properties (bootstrap-vue#1868) perf(modal): optimize model.resetScrollbar, resolves bootstrap-vue#1831 (bootstrap-vue#1837) docs: Update images reference section (bootstrap-vue#1999) fix(observe-dom): fix comment typo (bootstrap-vue#2084) chore(modal): trivial word fix in comment (bootstrap-vue#2089) (docs): Fix grammer in Intro readme (bootstrap-vue#2092) fix(modal): prevent scrolling on .modal-content focus, fixes bootstrap-vue#1748 (bootstrap-vue#2060) feat(pagination): added slots for first, prev, next, last, and ellipsis. Fixes bootstrap-vue#1870. (bootstrap-vue#1980) Handle state change on validated fields. (bootstrap-vue#1984) fix(docs): input group prepend slot typo (bootstrap-vue#2059) fix(dependencies): replace opencollective with opencollective-postintall (bootstrap-vue#2067) fix(docs): change b-input-group attribute 'left' to 'prepend' (bootstrap-vue#2017) ...
|
Hmmm, we are looking at making modal support multiple modals opened at a time, and basically We may have to change how this is done, since the modal that was first opened may not be the modal that is closed last, and may not have a reference of the elements I think we will have to change from storing the remembered lists of adjustments on the modal instance ( I'll work on a PR that can handle the new requirements, while still keeping the destroy process somewhat fast. |
modal resetScrollbar should revert the change only when the change was done in the first place