Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings on b-form-select open/close in recent Chrome #1858

Closed
chrismurf opened this issue May 29, 2018 · 11 comments · Fixed by #2419
Closed

Warnings on b-form-select open/close in recent Chrome #1858

chrismurf opened this issue May 29, 2018 · 11 comments · Fixed by #2419
Assignees

Comments

@chrismurf
Copy link

chrismurf commented May 29, 2018

To recreate:
Go to https://bootstrap-vue.js.org/play/ in Chrome v66 (I believe v51 or newer) and enter the following template:

  <b-form-select>
      <option>Sample</option>
  </b-form-select>

Then open and close the resulting select input several times.

Expected:
Developer console free of warnings and errors.

Actual:
See the following warning in the JavaScript console:

[Violation] Added non-passive event listener to a scroll-blocking 'mousewheel' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952

@chrismurf
Copy link
Author

See https://github.com/WICG/EventListenerOptions/blob/gh-pages/explainer.md for a better explanation of the cause.

@itsGabriel
Copy link

Any news?

@tmorehouse
Copy link
Member

I don't think we add any mousewheel events to b-form-select, but we will investigate

@a21ns1g4ts
Copy link

I have error in b-form-select:
[Violation] Added non-passive event listener to a scroll-blocking 'mousewheel' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952

@tmorehouse
Copy link
Member

I'm still not sure what would be causing this. b-form-select does not instantiate any 'mousewheel' listeners at all. It has to be something else adding them in.

Do you have any other plugins that may be installing listeners (such as validation)?

@tmorehouse
Copy link
Member

I think it might be docs use of v-b-scroll-spy directive... which monitors the page scrolling to highlight the current page section TOC (on the right hand side).

We'll have to update our eventOn handler to detect support of the passive option (not all browsers support it, and if present treat it as wanting to use capture mode).

Will see what we can do over the next week.

@tmorehouse tmorehouse self-assigned this Nov 10, 2018
@jacobmllr95
Copy link
Member

Is this still an issue in Chrome v70? I can't reproduce this.

@tmorehouse
Copy link
Member

I think you need to set a flag/option in developer tools to show the warnings.

I know code-mirror editor uses non passive events, which will also show up.

@jacobmllr95
Copy link
Member

@tmorehouse I have all log-levels selected.

@tmorehouse
Copy link
Member

Ok, maybe it is because v70 (I think) defaults most document listeners to passive by default.

@tmorehouse
Copy link
Member

My work laptop still has chrome v60 (can't update it as it is controlled by work IT department), and I see the warning crop up once and a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants