Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Navbar items in 0.12.3 #231

Closed
dmelikhov opened this issue Apr 13, 2017 · 5 comments
Closed

Incorrect Navbar items in 0.12.3 #231

dmelikhov opened this issue Apr 13, 2017 · 5 comments

Comments

@dmelikhov
Copy link

image

@pi0
Copy link
Member

pi0 commented Apr 13, 2017

Ops! This is related to 1518011 :( I think we should force PRs to provide screenshots to prevent this mistakes.) Will work on it.

@pi0
Copy link
Member

pi0 commented Apr 13, 2017

@Dibro89 Thanks for report. fixed in v0.12.4 :)

@pi0 pi0 closed this as completed Apr 13, 2017
@cynecx
Copy link

cynecx commented Apr 13, 2017

Oh, I didn't notice that because I've probably styled this with css already.
@pi0 Do you think adding this as a prop (isButton? or just button) would be a better idea?

@pi0
Copy link
Member

pi0 commented Apr 13, 2017

@cynecx If you want to just detect links without href and correct cursor on them why not using css selectors ?

a:not([href]) {
    /* Styles for anchors without href */
}

Is there any other special use case ?

@cynecx
Copy link

cynecx commented Apr 13, 2017

@pi0 That's funny because I haven't thought of that. Thank you for the suggestion ;).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants