-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(table): don't use css grid
for stacked table SCSS - for IE11 compatibility (closes #3307)
#3383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor adjustments to SCSS stacked table grid layout to allow for IE11 compatibility when using autoprefixer with `grid: true` set Closes #3307
Codecov Report
@@ Coverage Diff @@
## dev #3383 +/- ##
=======================================
Coverage 99.23% 99.23%
=======================================
Files 219 219
Lines 4186 4186
Branches 1215 1215
=======================================
Hits 4154 4154
Misses 26 26
Partials 6 6 Continue to review full report at Codecov.
|
It appears that IE11 does not support gid layout on psuedo elements |
tmorehouse
changed the title
fix(table): SCSS stacked table adjustments for IE11 compatibility
fix(table): SCSS stacked table for IE11 compatibility
May 26, 2019
tmorehouse
changed the title
fix(table): SCSS stacked table for IE11 compatibility
fix(table): adjust SCSS stacked table for IE11 compatibility
May 26, 2019
tmorehouse
changed the title
fix(table): adjust SCSS stacked table for IE11 compatibility
fix(table): adjust stacked table SCSS for IE11 compatibility (closes #3307)
May 26, 2019
tmorehouse
changed the title
fix(table): adjust stacked table SCSS for IE11 compatibility (closes #3307)
fix(table): don't use css May 26, 2019
grid
for stacked table SCSS - for IE11 compatibility (closes #3307)
jacobmllr95
approved these changes
May 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Switch from
grid
layout to old-schoolfloat: left
for stacked table layout, as IE11 does not supportdisplay: grid
layout on pseudo elements (the stacked cell heading is generated with a:before
pseudo element)Closes #3307
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples, fix typos
,chore: fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: