Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): don't use css grid for stacked table SCSS - for IE11 compatibility (closes #3307) #3383

Merged
merged 18 commits into from
May 26, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented May 25, 2019

Describe the PR

Switch from grid layout to old-school float: left for stacked table layout, as IE11 does not support display: grid layout on pseudo elements (the stacked cell heading is generated with a :before pseudo element)

Closes #3307

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe) SCSS update

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Minor adjustments to SCSS stacked table grid layout to allow for IE11 compatibility when using autoprefixer with `grid: true` set

Closes #3307
@codecov
Copy link

codecov bot commented May 25, 2019

Codecov Report

Merging #3383 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3383   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files         219      219           
  Lines        4186     4186           
  Branches     1215     1215           
=======================================
  Hits         4154     4154           
  Misses         26       26           
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fe6dd7...455685d. Read the comment docs.

@tmorehouse
Copy link
Member Author

It appears that IE11 does not support gid layout on psuedo elements

@tmorehouse tmorehouse changed the title fix(table): SCSS stacked table adjustments for IE11 compatibility fix(table): SCSS stacked table for IE11 compatibility May 26, 2019
@tmorehouse tmorehouse changed the title fix(table): SCSS stacked table for IE11 compatibility fix(table): adjust SCSS stacked table for IE11 compatibility May 26, 2019
@tmorehouse tmorehouse changed the title fix(table): adjust SCSS stacked table for IE11 compatibility fix(table): adjust stacked table SCSS for IE11 compatibility (closes #3307) May 26, 2019
@tmorehouse tmorehouse changed the title fix(table): adjust stacked table SCSS for IE11 compatibility (closes #3307) fix(table): don't use css grid for stacked table SCSS - for IE11 compatibility (closes #3307) May 26, 2019
@tmorehouse tmorehouse merged commit ce19fc7 into dev May 26, 2019
@tmorehouse tmorehouse deleted the tmorehouse/table-ie11 branch May 26, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

table SCSS: warning with autoprefixer grid: true option - IE11
2 participants