Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<b-table> Certain ARIA roles must contain particular children #3547

Closed
b-89 opened this issue Jun 19, 2019 · 8 comments · Fixed by #3553
Closed

<b-table> Certain ARIA roles must contain particular children #3547

b-89 opened this issue Jun 19, 2019 · 8 comments · Fixed by #3553
Assignees

Comments

@b-89
Copy link

b-89 commented Jun 19, 2019

Describe the bug

When using <b-table> with data and fields props set to an empty array, the table isn't passing the accessibility requirement that Certain ARIA roles must contain particular children. Reason both data and fields arrays are empty is because those are determined dynamically from the server response.

Steps to reproduce the bug

Setup a <b-table :data="[]" :fields="[]" />
Run axe devtools to analyze.

Expected behavior

If data is empty and fields is empty or isn't set, then there should be some kind of default behavior for the table to pass accessibility if the server fails to load the data.

Versions

Libraries:

  • BootstrapVue: 2.0.0-rc.15
  • Bootstrap: 4.3.1.
  • Vue: 2.6.10

Environment:

  • Device: hp
  • OS: Windows 10
  • Browser: Chrome
  • Version: Latest
@tmorehouse
Copy link
Member

Is this when using the empty slot, or jsut with the two empty arrays (items/fields)?

@tmorehouse
Copy link
Member

Also, which elements/roles are generating the issue?

@b-89
Copy link
Author

b-89 commented Jun 20, 2019

So the actual version we're using is using the empty slot as well, but I notice the <thead> and <tbody> being generated without it too. From what I noticed, it's a <tr> being empty inside the <thead> and <tbody>.

@tmorehouse
Copy link
Member

We may need to just add a conditional render for b-table, and render a placeholder comment if both fields and items are empty, and no empty slot present (there needs to be at least once header rendered for empty slot to work currently)

@b-89
Copy link
Author

b-89 commented Jun 20, 2019

Even when empty slot is used, the accessibility requirement is invalid for the <thead>.

@b-89
Copy link
Author

b-89 commented Jun 20, 2019

Could you not render the <thead> unless there is data or fields set?

@tmorehouse
Copy link
Member

Version 2.0.0-rc.25 has been released.

@b-89
Copy link
Author

b-89 commented Jul 1, 2019

Thanks man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants