New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(b-table): better sort labeling for screen readers (closes #4487) #4488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #4488 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 247 247
Lines 4855 4855
Branches 1363 1366 +3
=======================================
Hits 4851 4851
Misses 3 3
Partials 1 1
Continue to review full report at Codecov.
|
tmorehouse
changed the title
feat(b-table): better sort labeling for screen readers
feat(b-table): better sort labeling for screen readers (closes #4487)
Dec 11, 2019
jacobmllr95
approved these changes
Dec 12, 2019
This was referenced Jan 17, 2020
This was referenced Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Switch
click to sort ....
label from aria-label to an.sr-only
element in the field headerIf
aria-label
is present, most screen readers will not read the content of theth
cellThis moves the aria-label content into an sr-only hidden span within the header cell.
Closes #4487
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
One notable change is that if users use
labelHtml
in a field definition, the html will now be placed into adiv
element instead of directly in the TH element, so allow for concatenation of the sr-only sort labelThe PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: