Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Adding custom toolbar buttons is made slightly more awkward than necessary #39

Closed
Waxolunist opened this issue Sep 29, 2014 · 3 comments

Comments

@Waxolunist
Copy link
Contributor

Issue by cooperaj
Wednesday Feb 26, 2014 at 16:49 GMT
Originally opened as Waxolunist/bootstrap3-wysihtml5-bower#39


I'm utilising the underlying wysithtml5 libraries 'insertHTML' command on some custom buttons. To do this I've created a template that includes these commands and have added

custombuttons: true,

to my user options to get it to load. Only it doesn't load because the this library uses the defaultOptions to populate the toolbar and not the combined default/user options. To work around this I have added the above to the the underlying $.fn.wysihtml55.defaultOptions object. This realistically achieves the same but is not super intuitive.

@Waxolunist Waxolunist added this to the 0.2.9 milestone Sep 29, 2014
@Waxolunist
Copy link
Contributor Author

Comment by Waxolunist
Wednesday Feb 26, 2014 at 17:10 GMT


Can you give a fiddle for that, or a link to a repo?

@Waxolunist
Copy link
Contributor Author

Comment by cooperaj
Wednesday Feb 26, 2014 at 17:29 GMT


This doesn't work but details the code i'm using and the fix i've put in

http://jsfiddle.net/fdRR9/

@Waxolunist
Copy link
Contributor Author

Comment by Waxolunist
Friday Feb 28, 2014 at 15:15 GMT


Please have a look at v0.2.9. I think, this is what you intended to do.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant