Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial sentinel1 accessor that raises when not used on backend Dataset (more or less) #46

Closed
wants to merge 6 commits into from

Conversation

alexamici
Copy link
Member

@alexamici alexamici commented Apr 27, 2021

Objectives for the accessors are:

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2021

Codecov Report

Merging #46 (60eeaaf) into main (988a162) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   93.12%   93.32%   +0.19%     
==========================================
  Files           7        7              
  Lines         538      554      +16     
  Branches       62       64       +2     
==========================================
+ Hits          501      517      +16     
  Misses         20       20              
  Partials       17       17              
Impacted Files Coverage Δ
tests/test_xarray.py 100.00% <100.00%> (ø)
xarray_sentinel/sentinel1.py 95.02% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 988a162...60eeaaf. Read the comment docs.

@aurghs
Copy link
Member

aurghs commented Apr 29, 2021

this PR seems to be too big. I think we can split it into smaller ones. One for each point of the list.

@alexamici
Copy link
Member Author

I agree.

@alexamici alexamici closed this May 3, 2021
@alexamici alexamici deleted the sentinel1-accessor branch June 25, 2021 09:22
@alexamici alexamici restored the sentinel1-accessor branch June 25, 2021 09:22
@alexamici alexamici deleted the sentinel1-accessor branch January 4, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants