Skip to content
This repository has been archived by the owner on Jan 21, 2022. It is now read-only.

Randomness of random bytes #45

Closed
ad-m opened this issue Apr 18, 2017 · 2 comments
Closed

Randomness of random bytes #45

ad-m opened this issue Apr 18, 2017 · 2 comments

Comments

@ad-m
Copy link
Contributor

ad-m commented Apr 18, 2017

My awareness take how much randomness need to be in DisposablePeer.__random_bytes (https://github.com/boramalper/magnetico/blob/master/magneticod/magneticod/bittorrent.py#L289 ). It take 6% of total script time.

It really need to be random? Maybe it might be sequential?
@ngosang
Copy link
Contributor

ngosang commented Apr 19, 2017

Not need to be random, it works fine but it's not fully bittorrent compliance.

@ngosang ngosang mentioned this issue Apr 20, 2017
Merged
@ngosang
Copy link
Contributor

ngosang commented Apr 20, 2017

PR #43 increases random bytes generation speed by 31%

@ad-m ad-m closed this as completed Apr 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ad-m @ngosang