Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package reMarkable rM-vnc-server-standalone dependency in toltec #38

Closed
Eeems opened this issue Jan 5, 2021 · 5 comments
Closed

Package reMarkable rM-vnc-server-standalone dependency in toltec #38

Eeems opened this issue Jan 5, 2021 · 5 comments

Comments

@Eeems
Copy link
Contributor

Eeems commented Jan 5, 2021

Ideally this should be in toltec for easier distribution and updates.

@NickHu
Copy link

NickHu commented Jan 8, 2021

rM-vnc-server is written by @pl-semiotics so this should go here pl-semiotics/rM-vnc-server#7

@NickHu
Copy link

NickHu commented Jan 8, 2021

Why are the binaries duplicated in this repo anyway? It's quite redundant as they come from here: https://github.com/pl-semiotics/rM-vnc-server/releases

@Eeems
Copy link
Contributor Author

Eeems commented Jan 8, 2021

@NickHu I think you'll find that a lot of GitHub repositories have external dependency binaries added to their repo.

Thanks for pointing out that I opened this on the wrong repo though, I guess I wasn't looking closely enough at the readme and thought it was part of this project.

@Eeems Eeems closed this as completed Jan 8, 2021
@NickHu
Copy link

NickHu commented Jan 8, 2021

Git repositories are not meant for storing binaries. The autoinstall that this package provides of rM-vnc-server can be replaced with wget and chmod +x which are already installed on the reMarkable; nonetheless, the best solution is probably to have it in a centralised package manager

@Eeems
Copy link
Contributor Author

Eeems commented Jan 8, 2021

Git repositories are not meant for storing binaries.

As I keep telling my coworkers.

The autoinstall that this package provides of rM-vnc-server can be replaced with wget and chmod +x which are already installed on the reMarkable; nonetheless, the best solution is probably to have it in a centralised package manager

For sure, and it can also validate the binary with a sha256sum like toltec does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants