Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS8/10.10 vs Apple's NSCalendar/NSDate refactoring... time for fork? #44

Open
dhmspector opened this issue Nov 21, 2014 · 2 comments
Open

Comments

@dhmspector
Copy link

So, under iOS8 (and, I presume, Yosemite, since this is about a foundation class) presents a number of deprecation warnings -- mostly things like constants who names have changed, when trying to compile the date formatter, e.g.:

ISO8601DateFormatter.m:216:86: warning: 'NSMonthCalendarUnit' is deprecated: first deprecated in iOS 8.0 - Use NSCalendarUnitMonth instead

These could be fixed by conditionalizing the code, but that will get very ugly instantaneously - is there a plan to address this in another way? Would it make sense to make a "modern" fork for people using iOS8/Yosemite and above?

@boredzo
Copy link
Owner

boredzo commented Nov 22, 2014

I'd be fine with something that defines NSCalendarUnitMonth, etc. if they haven't already been defined by the SDK headers. Second best would be conditionally defining ISO8601CalendarUnitMonth, etc. to one or the other.

@boredzo
Copy link
Owner

boredzo commented Apr 17, 2016

0.9 will move away from older, deprecated API names to newer, not-so-deprecated API names. For that release, a simple find-and-replace would be fine.

@boredzo boredzo modified the milestones: 1.0, 0.9.0 Apr 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants