Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSX closing tags don't match style #56

Closed
AlexKvazos opened this issue Jan 30, 2018 · 5 comments
Closed

JSX closing tags don't match style #56

AlexKvazos opened this issue Jan 30, 2018 · 5 comments

Comments

@AlexKvazos
Copy link

The opening and closing div tags have a different color and it is pretty annoying coming from the babel syntax to see this change.

screen shot 2018-01-30 at 4 27 27 pm

@borela
Copy link
Owner

borela commented Jan 30, 2018

What color scheme are you using?

@borela
Copy link
Owner

borela commented Jan 30, 2018

It was a bug in the syntax, in the develop branch I already patched it, I will release the patch.

@borela
Copy link
Owner

borela commented Jan 30, 2018

Fixed https://github.com/borela/naomi/releases/tag/v3.3.4

@borela borela closed this as completed Jan 30, 2018
@AlexKvazos
Copy link
Author

Omg this was one hell of a fast response. Thank you very much! Definitely sticking with FXJS15 for now.

Why not contribute to babel for the jsx/javascript syntax? Sublime's community is not as big as it was and having two definitions just makes it worse.

@borela
Copy link
Owner

borela commented Jan 31, 2018

You are welcome :D
I considered it but babel sublime is trying to support atom too, so they require that you code it using the tmLanguage instead of the sublime syntax definitions #21

Some of the features I use don't exist in the tmLanguage. Sublime syntaxes are not without its flaws #25 I still can't predict multi line arrow functions, but as far as I know, tmLanguage has this limitation too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants