Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove scp syntax #6691

Closed
ThomasWaldmann opened this issue May 13, 2022 · 2 comments
Closed

remove scp syntax #6691

ThomasWaldmann opened this issue May 13, 2022 · 2 comments

Comments

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented May 13, 2022

borg uses regexes to parse the location argument given to it on the commandline.

these regexes are a rather complex and at least the scp-style location regex also tends to mismatches, because it is used for:

  • local repos (just giving a fs path as the repo)
  • remote repos (which can be also given via the ssh:// url syntax, which is less limited and clearly a remote repo)

that the user often can also give an archive name within a LOCATION specifier makes it even a bit more complex, but that is the topic of #948.

one more bad thing about scp-style is that one can not give a ssh port within it. so we also need docs / FAQ entries telling the user to not use that style if the port is not 22. also we need examples for both styles...

so, the plan is to just remove scp-style syntax. less code, less docs, less hard to debug/fix regex issues.

obviously this is a breaking change as users who use that style will have to edit their scripts / configs to use ssh url style.

bounty: https://app.bountysource.com/issues/108445136-remove-scp-syntax

@ThomasWaldmann
Copy link
Member Author

btw, in case somebody is wondering about the USD 41.85 bounty amount: that was just the remainder before the organisation funds went to zero.

@ThomasWaldmann
Copy link
Member Author

Crap, I was a little fast with merging this.

The idea was to merge this IF the other breaking changes are also merged.
But anyway, either we do that or we'll revert this change later again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant