Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2 docs: update --prefix to --glob-archives #7031

Closed
ThomasWaldmann opened this issue Sep 16, 2022 · 11 comments
Closed

1.2 docs: update --prefix to --glob-archives #7031

ThomasWaldmann opened this issue Sep 16, 2022 · 11 comments

Comments

@ThomasWaldmann
Copy link
Member

https://borgbackup.readthedocs.io/en/stable/quickstart.html#automating-backups

Warning: "--prefix" has been deprecated. Use "--glob-archives 'yourprefix*'" (-a) instead.
@ThomasWaldmann
Copy link
Member Author

Also, we maybe should remove that final line-continuation backslash in the commands.

@Mannuel25
Copy link

Hello @ThomasWaldmann , I'd love to take this up, but I can't find --prefix in the quickstart file. Could you please show me the file that is to be updated.

Also, I don't understand what you mean here: we maybe should remove that final line-continuation backslash in the commands.

@ThomasWaldmann
Copy link
Member Author

@Mannuel25 did you look into the 1.2-maint branch (not: master)?

@ThomasWaldmann
Copy link
Member Author

borg prune                          \
    --list                          \
    --prefix '{hostname}-'          \
    --show-rc                       \
    --keep-daily    7               \
    --keep-weekly   4               \
    --keep-monthly  6               \

The last backslash there is not needed, because the command is not really continued on the next line (which is empty).

One change for prune, once for create.

@Mannuel25
Copy link

@Mannuel25 did you look into the 1.2-maint branch (not: master)?

Oh, I didn't. I've seen it now. Thanks

@Mannuel25
Copy link

borg prune                          \
    --list                          \
    --prefix '{hostname}-'          \
    --show-rc                       \
    --keep-daily    7               \
    --keep-weekly   4               \
    --keep-monthly  6               \

The last backslash there is not needed, because the command is not really continued on the next line (which is empty).

One change for prune, once for create.

Got that. Thank you.

@i-m-karanagarwal
Copy link

Is this still Open for contribution?

@ThomasWaldmann
Copy link
Member Author

@i-m-karanagarwal sure, it is still open, just make a PR!

@Mannuel25
Copy link

@i-m-karanagarwal sure, it is still open, just make a PR!

Hi @ThomasWaldmann , I thought I fixed this already

@ThomasWaldmann
Copy link
Member Author

@Mannuel25 oops, yes, correct: #7039

@ThomasWaldmann
Copy link
Member Author

In master, a similar fix was done, so this is solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants