Orphaned objects check skipped (needs all archives checked). #7752
Comments
|
Well, if you want all archives check, why do you use The borg code just checks for presence of limiting options and then assumes that this means not all archives are checked. But maybe it is a good idea to change that code to rather check the set difference between the to-be-checked archives and the all-archives set. |
It's not called by "me" its called like this by borgmatic because of my Ref: https://projects.torsion.org/borgmatic-collective/borgmatic/issues/734#issuecomment-6822 |
|
OK. Well, guess this could be fixed by both borg (as I described above) and borgmatic (checking for |
|
I am not 100% sure if this is the right way but I would find it cleaner if borg would check the difference between the to-be-checked archives and the all-archives set. |
|
Just checked the code: it's not as easy as I thought - there are also checkpoint archives (which are not considered if any of the first, last, glob/match, older, newer, newest, oldest options is given, but are considered in absence of these). |
|
FWIW, borgmatic will make the fix on the borgmatic side as part of https://projects.torsion.org/borgmatic-collective/borgmatic/issues/734 |
|
So, guess for borg 1.2, this works as designed / as expected. Also not sure if we can do this better for borg 2, because most borg commands ignore checkpoint archives, except when --consider-checkpoints is given. OTOH, borg check (without options) does consider checkpoints by default (so it really checks all archives by default), but it would be unexpected if it would consider them also when using matching, first/last etc.. So guess there is no better solution. |
Have you checked borgbackup docs, FAQ, and open GitHub issues?
Yes
Is this a BUG / ISSUE report or a QUESTION?
BUG
Your borg version (borg -V).
borg 1.2.4
Operating system (distribution) and version.
EndeavourOS Linux x86_64 6.4.7-zen1-1-zen
Full borg commandline that lead to the problem (leave away excludes and passwords)
borg check --repair --archives-only --glob-archives * --lock-wait 5 --debug --show-rc --progress --save-space ssh://x@x.com:22/./repo.borg
Describe the problem you're observing.
I originally opened the issue in the Borgmatic repo, but realized that it's probably more of a problem with borg itself.
If you use the parameter
--glob-archivesthe "Orphaned objects check" is skipped, even if the filter includes all archives.Include any warning/errors/backtraces from the system logs
You can see here all 42 archives get Analyzed but still the Orphaned objects check is skipped.
The text was updated successfully, but these errors were encountered: