Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff doesn't show the modified status or size of change for files anymore #1016

Closed
Victor239 opened this issue Jun 15, 2021 · 5 comments
Closed
Labels
priority:medium Non-critical improvement to functionality or usability type:bug Something doesn't work as intended

Comments

@Victor239
Copy link

Describe the bug
When I did my first two backups with Vorta doing a diff between them seemed to work fine - every file was either green, red or yellow and showed the size of the change. I've done a third one, but now that I try to diff between any two backups it only shows me the modified status and size change for one file despite there being 3.7GB of changes:

This is using borgbase.com as a remote repo.

To Reproduce
Steps to reproduce the behavior:

  1. Create 3 backups for a single repo to borgbase.com
  2. Try to diff any of the 2 backups
  3. See error

Environment (please complete the following information):

  • OS: Kubuntu 21.04
  • Vorta version: 0.7.6
  • Installed from: Flatpak

Additional context
Let me know if there's anything else needed to troubleshoot this.

@m3nu
Copy link
Contributor

m3nu commented Jun 17, 2021

I can confirm that the output of this dialog changed between v0.7.5 and v0.7.6. Probably related to #909. Maybe @rblenis can weigh in?

@m3nu m3nu added priority:medium Non-critical improvement to functionality or usability type:bug Something doesn't work as intended labels Jun 17, 2021
@Hofer-Julian
Copy link
Collaborator

Can confirm, the details of the change are not present any more.

@bastiencyr
Copy link
Collaborator

bastiencyr commented Jun 18, 2021

Im sorry, its clearly related to #999 :( I'm working on fix, I will open a PR soon.
Notice that making diff between two repo without any differences will result in failure :

Uncaught exception, please file a report with this text at
https://github.com/borgbase/vorta/issues/new
Traceback (most recent call last):
  File "/home/bastien/Documents/Travail/Vorta/vorta/src/vorta/views/archive_tab.py", line 558, in list_diff_result
    window = DiffResult(result['data'], archive_newer, archive_older, result['params']['json_lines'])
  File "/home/bastien/Documents/Travail/Vorta/vorta/src/vorta/views/diff_result.py", line 35, in __init__
    files_with_attributes = [attrs + (type_f, ) for attrs, type_f in zip(files_with_attributes, fs_data[1])]
IndexError: string index out of range

@m3nu
Copy link
Contributor

m3nu commented Jun 18, 2021

Oh, great. Waiting for your PR.

@m3nu m3nu closed this as completed in 5700f09 Jun 20, 2021
@rblenis
Copy link
Contributor

rblenis commented Jun 22, 2021

sorry, been tied up at work. glad someone is taking a look. I'm available to review or help out if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:medium Non-critical improvement to functionality or usability type:bug Something doesn't work as intended
Projects
None yet
Development

No branches or pull requests

5 participants