Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should update to match the new spec #26

Open
zcorpan opened this issue Aug 11, 2014 · 4 comments
Open

Should update to match the new spec #26

zcorpan opened this issue Aug 11, 2014 · 4 comments

Comments

@zcorpan
Copy link

zcorpan commented Aug 11, 2014

It looks like this polyfill implements the old spec for srcset, where 'w' descriptors meant viewport max-width. The current spec makes 'w' descriptors mean width of the image, to be used together with the sizes attribute. The functionality for the old 'w' is available by using the picture element.

@booleanbetrayal
Copy link

@zcorpan - Unless I'm mistaken, the polyfill seems correct. According to the latest working spec (Nov 13 2014):

To specify an image, give first a URL, then one or more descriptors of the form 100w or 2x, where "100w" means "maximum viewport width of 100 CSS pixels" and "2x" means "maximum pixel density of 2 device pixels per CSS pixel".

@zcorpan
Copy link
Author

zcorpan commented Dec 2, 2014

@fischhase
Copy link

zcorpan is right.
ResponsiveImagesCG/picture-element#253
Problem: Opera and Chrome blows up images to 100% of viewport; even if the source-image is smaller in size.

@abernier
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants