Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add phantomjs-node type definition file #3255

Merged
merged 2 commits into from
Dec 1, 2014

Conversation

horiuchi
Copy link
Member

@horiuchi horiuchi commented Dec 1, 2014

Add type definition file for https://www.npmjs.org/package/phantom

@vvakame
Copy link
Member

vvakame commented Dec 1, 2014

@horiuchi thank you for your contributions.
please rename phantomjs-node/phantomjs-node.d.ts to phantom/phantom.d.ts
http://definitelytyped.org/guides/contributing.html#naming-the-file

@horiuchi
Copy link
Member Author

horiuchi commented Dec 1, 2014

@vvakame OK, renamed files.

vvakame added a commit that referenced this pull request Dec 1, 2014
add phantomjs-node type definition file
@vvakame vvakame merged commit fa7415a into DefinitelyTyped:master Dec 1, 2014
@vvakame
Copy link
Member

vvakame commented Dec 1, 2014

@horiuchi thanks mate!

@horiuchi
Copy link
Member Author

horiuchi commented Dec 1, 2014

@vvakame Thank you for reviewing.

@horiuchi horiuchi deleted the phantomjs-node branch March 3, 2015 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants