Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#495] add clojure.java.browse/browse-url #496

Merged
merged 2 commits into from
Jun 23, 2020
Merged

[#495] add clojure.java.browse/browse-url #496

merged 2 commits into from
Jun 23, 2020

Conversation

borkdude
Copy link
Collaborator

@borkdude borkdude commented Jun 23, 2020

Fixes #495.
cc @lread

One issue remains to be fixed on Windows:

C:\Users\borkdude\Downloads>bb -e "(require '[clojure.java.browse :refer [browse-url]]) (browse-url \"https://babashka.org\")"
java.io.IOException: Cannot run program "start": CreateProcess error=2, The system cannot find the file specified [at line 1, column 54]

This seems to work:

> bb -e "(require '[clojure.java.shell :refer [sh]]) (sh \"cmd.exe\" \"/C\" \"start\" \"https://babashka.org\")"
{:exit 0, :out "", :err ""}

@borkdude borkdude merged commit 6332640 into master Jun 23, 2020
@borkdude borkdude deleted the java-browse branch June 23, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add clojure.java.browse/browse-url
1 participant