Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds three lines of docs to example web server #416

Merged
merged 3 commits into from May 8, 2020
Merged

Adds three lines of docs to example web server #416

merged 3 commits into from May 8, 2020

Conversation

bherrmann7
Copy link
Contributor

I found it confusing that the example web server only accepted a single connection. I tried to add some documentation to call this out.

@borkdude
Copy link
Collaborator

borkdude commented May 7, 2020

@bherrmann7 I would also be fine with a PR to make it multi-threaded. What do you think?

@bherrmann7
Copy link
Contributor Author

I would like that, but I'm afraid I will destroy the simplicity. However, it is probably the more common use case. I will what I can do to meet both constraints.

@borkdude borkdude merged commit 97c4819 into babashka:master May 8, 2020
@borkdude
Copy link
Collaborator

borkdude commented May 8, 2020

For now I'll just merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants