Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add predicates + type function to hooks api to rely less on api/sexpr #1006

Closed
borkdude opened this issue Sep 11, 2020 · 0 comments
Closed

Add predicates + type function to hooks api to rely less on api/sexpr #1006

borkdude opened this issue Sep 11, 2020 · 0 comments
Labels
hooks
Projects
clj-kondo

Comments

@borkdude
Copy link
Member

borkdude commented Sep 11, 2020 •
edited

I want to add predicates api/vector?, api/symbol? etc so people rely less on api/sexpr which can be a footgun (it throws when the node is malformed, like {:a}. Also a type function which returns something like :vector which you can dispatch on would be nice.

Related: lread/rewrite-cljc-playground#5
@borkdude borkdude added the hooks label Sep 11, 2020
@borkdude borkdude added this to Needs triage in clj-kondo via automation Sep 11, 2020
@borkdude borkdude moved this from Needs triage to Medium priority (new / enhance) in clj-kondo Sep 11, 2020
@borkdude borkdude moved this from Medium priority (new / enhance) to High priority (next release) in clj-kondo Sep 11, 2020
@borkdude borkdude mentioned this issue Sep 11, 2020
Merged
borkdude added a commit that referenced this issue Oct 6, 2020
@borkdude
[#1006] Add hook predicates
e180705
@borkdude borkdude moved this from High priority (next release) to Next release in clj-kondo Oct 6, 2020
borkdude added a commit that referenced this issue Oct 6, 2020
@borkdude
[#1006] Add hook predicates
fde03c2
clj-kondo automation moved this from Next release to Done Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hooks
Projects
clj-kondo
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@borkdude